Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

zsh completion fails if jq is not installed #498

Open
triallax opened this issue Sep 14, 2022 · 3 comments
Open

zsh completion fails if jq is not installed #498

triallax opened this issue Sep 14, 2022 · 3 comments
Labels
bug contributions welcome Further design discussions and PRs are welcome.

Comments

@triallax
Copy link
Contributor

triallax commented Sep 14, 2022

% todo cancel <TAB>
__todo_tasks:[:4: unknown condition: -lt
__todo_tasks:12: command not found: jq
Error: No configuration file found.


For details on the configuration format and a sample file, see
https://todoman.rtfd.org/en/latest/configure.html

(The "Error: No configuration file found." thing is probably because I don't actually have Todoman set up.)

<TAB> here means pressing the tab button. Also, to be clear, todo <TAB> shows the available subcommands just fine.

zsh version is 5.8.1, Todoman is 4.1.0 installed from Homebrew.

@WhyNotHugo
Copy link
Member

Please report this to homebrew, they should list jq as an (optional?) dependency.

I guess the autocomplete could fall back gracefully is jq is absent tho.

@WhyNotHugo WhyNotHugo added the bug label Nov 3, 2022
@WhyNotHugo
Copy link
Member

Documented in aa738c6

cc: @pimutils/packaging jq is necessary for auto-complete. For platforms where zsh is the default shell, I suggest adding it as a dependency, for others adding it as an optional dependency should suffice.

@triallax
Copy link
Contributor Author

triallax commented Nov 4, 2022

Please report this to homebrew, they should list jq as an (optional?) dependency.

I already added jq as a dependency in Homebrew/homebrew-core#110702 (homebrew-core does not allow optional dependencies).

I guess the autocomplete could fall back gracefully is jq is absent tho.

Yeah, that was what I intended to say.

@WhyNotHugo WhyNotHugo added the contributions welcome Further design discussions and PRs are welcome. label Nov 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug contributions welcome Further design discussions and PRs are welcome.
Projects
None yet
Development

No branches or pull requests

2 participants