-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Autoprefix styles #9
Comments
+1 for this! |
This is on the todo list. I don't think I want to enable it by default, so I think I'll make it an option in the {Gasp}... I guess that counts as configuration! 😃 |
Woot 🙌 sounds good! |
I think that's an acceptable config! Btw - I know you're going for a no config required with this, but for some advanced options - this for example - I think having some config options is perfectly acceptable! |
This tool is fantastic but the lack of auto-prefixer stops me using it for now - don't think I've ever had a gulp (or brunch) config without auto-prefixing. Is there any reason why prefixing couldn't just be built-in? Rather than an "advanced option"? (ie. does it break / cause problems with any common workflows?) |
@sjclark My issue is that vendor-prefixes are not being used by browser vendors anymore, so I'm wary of adding bloat that won't be so relevant in a couple of years. Having said that, I'll add it as a configuration option. Might be ready by tomorrow. |
Guess thats the key, still very relevant for now - i know you're anti-config but what if you had a vendor-prefix config line that just took the arguments ie: Even with that config line above (which I consider liberal) my clients complain that "Oh, it doesn't seem to work on my daughters iPad" - although everyone signs a contract that stipulates it will support the latest version of IE, Edge, Chrome (&mobile), Firefox, and nothing else. Clients be clients. |
That's exactly what I'm doing, hopefully it will be ready for tomorrow. |
Thanks for this project. Been using gulp from the very start and autoprefix is the essential feature. Will wait for pingy to mature, then going to give it another chance. |
Hey everyone, this is available in 0.7.0 beta. 🎉 Details of the release and how to install it are here: https://github.com/pingyhq/pingy-cli/releases/tag/%40pingy%2Fcli%400.7.0 I would very much appreciate your help in testing it out. 👍 |
This is working well for me! |
You could use the browsers field in package.json which it seems the community is converging on. If it's there, autoprefix. If it's not, don't. I think that would be a fair convention |
@Munter Good idea, I didn't know about that. I'll add support 👍. |
@davej Looks like you won't even have to: https://github.com/ai/browserslist/blob/master/index.js#L158-L288 Seems you can use this to get the config from the already supported configuration conventions. Then decide what to do based on the return value I think. |
This is out of beta for I'm not adding UsageTo enable autoprefix then just add the following entry to your
This will default to autoprefixing for the last 2 browser versions if set to |
Closing as this feature is considered stable as of v0.10. Support for the |
Great job with Pingy CLI! Super cool.
The only thing I feel like I'm missing is autoprefixing of styles, any way to add that myself? Or plans to add it?
The text was updated successfully, but these errors were encountered: