Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add new experimental rule no-empty-file #1963

Closed
wants to merge 84 commits into from

Conversation

ao0000
Copy link
Contributor

@ao0000 ao0000 commented Apr 22, 2023

Description

Add new experimental rule no-empty-file for all code style.
This rule disallow empty files.

Close #1074

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

@ao0000 ao0000 marked this pull request as ready for review April 22, 2023 02:12
Copy link
Collaborator

@paul-dingemans paul-dingemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for your contribution. Please address the issues. As we have just released version 0.49.0, it might take a while (a couple of months) before the rule will be released. Merging of the rule will be delayed until the 0.49.x is considered stable and will not receive any other patch versions.

@paul-dingemans paul-dingemans added this to the 1.0 (Yeah!) milestone Apr 22, 2023
@paul-dingemans paul-dingemans marked this pull request as draft April 22, 2023 16:55
@ao0000 ao0000 requested a review from paul-dingemans April 26, 2023 14:12
Copy link
Collaborator

@paul-dingemans paul-dingemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged in 1.0

@paul-dingemans
Copy link
Collaborator

Replaced by #2025. I potentially messed up with rebasing on 0.49.1 as the PR now contains 114 changed files instead of 5.

paul-dingemans added a commit that referenced this pull request May 27, 2023
* Add new experimental rule `no-empty-file` for all code styles. Kotlin file may not be empty.

Co-authored-by: ao0000 <ao0000dev@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Rule: Empty file
5 participants