Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Increase test coverage #92

Open
enobufs opened this issue Aug 29, 2019 · 4 comments
Open

Increase test coverage #92

enobufs opened this issue Aug 29, 2019 · 4 comments
Assignees
@enobufs

Comments

@enobufs
Copy link
Member

enobufs commented Aug 29, 2019

We've seen a few bugs in pion/turn which could have been easily detected earlier if there were sufficient test coverage. With this ticket, let's aim for 80%+ coverage at least for ./internal/client package.
@enobufs enobufs self-assigned this Aug 29, 2019
@songjiayang
Copy link
Member

I hope that I can contribute a little strength 🆙

@Sean-Der
Copy link
Member

I just added +4% with Client+Server tests for stale nonces!

@songjiayang @enobufs I will start a list of easy wins people can write tests for :) this is also a good chance to refactor/cleanup anything we run into.

@Sean-Der
Copy link
Member

The client code has quite a few refresh related things that aren't tested.

We should allow the server to have very short expiration times, and then force things to be run conn.go

@Sean-Der
Copy link
Member

The server has quite a few easy tests as well, we can send invalid packets in and confirm that an error gets returned/things don't crash turn.go should be easy to test

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@enobufs enobufs

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enobufs @Sean-Der @songjiayang