Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change parameter used in dtm_coherence() (in DTM wrapper) to avoid persistent warning #2925

Closed
MeganStodel opened this issue Aug 28, 2020 · 3 comments · Fixed by #2926
Closed

Comments

@MeganStodel
Copy link
Contributor

Within the DTM wrapper, using dtm_coherence() always produces a warning:

"The parameter num_words is deprecated, will be removed in 4.0.0, use topn instead."

Although the function works, obviously the intention is to deprecate the parameter at some point.

This can be tracked back to show_topic(), which is where num_words has switched to topn. It is a very simple fix to just change the parameter used in the dtm_coherence() function accordingly.

PR incoming with fix.

@piskvorky
Copy link
Owner

piskvorky commented Aug 28, 2020

Thanks. @MeganStodel what do you use DTM for? What's your motivation, context?

We're seriously considering removing all third party wrappers from Gensim: Mallet, DTM, etc. So any feedback on which parts are still in use & relevant, and why, is appreciated.

@MeganStodel
Copy link
Contributor Author

Thanks @piskvorky, that's interesting!

I use Mallet regularly and have just started exploring DTM. With DTM, I know there is another implementation in gensim (ldaseqmodel) but I found this much, much slower than using the wrapper. The wrappers in gensim are the only route I know for applying Mallet and DTM models in python, so would definitely feel their loss.

@piskvorky
Copy link
Owner

Thanks Megan, duly noted.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants