Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[connector] replace Trino DictionaryBlock with our own implementation #86

Open
bianhq opened this issue Jan 10, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bianhq
Copy link
Contributor

bianhq commented Jan 10, 2024

Currently, Trino DictionaryBlock stores null value in the dictionary. This is weird and is not compatible with the way that Pixels DictionaryColumnVector handles null values.
In Issue #84, we fix this problem by appending a null value to the dictionary block if there are null values in the column vector. However, this is inefficient as it leads to memory copies and array iterations. We should add our own DictionaryBlock implementation.

@bianhq bianhq added the enhancement New feature or request label Jan 10, 2024
@bianhq bianhq added this to the Compatibility milestone Jan 10, 2024
@bianhq bianhq self-assigned this Jan 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant