Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PIXELS-226]: port pixels-presto #2

Merged
merged 4 commits into from
Apr 10, 2022
Merged

[PIXELS-226]: port pixels-presto #2

merged 4 commits into from
Apr 10, 2022

Conversation

xxchan
Copy link
Contributor

@xxchan xxchan commented Apr 3, 2022

closes #1

Basic functionalities (select) are supported (Didn't fully test all features):

image

image

The code is basically copied from pixels-presto. Changes are:

  • Some simple API changes are fixed. There are still some non-trivial changes left as TODO, e.g., createView
  • Fixed a strange gRPC error by adding dependency in pom.xml. (It costed me days 🙃)

cc @bianhq

@xxchan xxchan marked this pull request as ready for review April 7, 2022 21:37
@xxchan xxchan changed the title WIP: port pixels-presto port pixels-presto Apr 7, 2022
@bianhq bianhq merged commit c997a31 into pixelsdb:master Apr 10, 2022
@bianhq
Copy link
Contributor

bianhq commented Apr 10, 2022

Thanks for this great job!
I am going to add the copyright headers that are missing in some files and test TPC-H queries next week.

@bianhq bianhq changed the title port pixels-presto [PIXELS-226]: port pixels-presto Apr 10, 2022
@bianhq bianhq added the enhancement New feature or request label Oct 16, 2024
@bianhq bianhq self-requested a review October 16, 2024 04:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[connector] implement basic functionalities.
2 participants