Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PIXELS-403] fix comments. #63

Merged
merged 1 commit into from
Feb 27, 2023
Merged

[PIXELS-403] fix comments. #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions connector/src/main/java/io/pixelsdb/pixels/trino/PixelsPageSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ public Page getNextPage()
return getNextPage();
} else
{
close();
this.close();
return null;
}
}
Expand Down Expand Up @@ -425,7 +425,7 @@ public Page getNextPage()
return getNextPage();
} else
{
close();
this.close();
return null;
}
}
Expand All @@ -442,6 +442,7 @@ public Page getNextPage()
@Override
public void close()
{
// PIXELS-403: page source is not accessed by multiple threads, there is no need to synchronize on this method.
if (closed)
{
return;
Expand All @@ -457,6 +458,9 @@ public void close()
closed = true;
}

/**
* Close the current pixels reader without closing this page source.
*/
private void closeReader()
{
try
Expand Down