Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cpp] fix duckdb benchmark_runner bugs #815

Open
whzruc opened this issue Dec 27, 2024 · 1 comment · May be fixed by #824
Open

[cpp] fix duckdb benchmark_runner bugs #815

whzruc opened this issue Dec 27, 2024 · 1 comment · May be fixed by #824
Assignees
Labels
bug Something isn't working
Milestone

Comments

@whzruc
Copy link
Collaborator

whzruc commented Dec 27, 2024

python run_benchmark_simple.py --dir=benchmark/clickbench/clickbench-pixels-e0-1ssd/

image
image
image
image

@whzruc whzruc added the bug Something isn't working label Dec 27, 2024
@whzruc whzruc added this to the Pixels C++ milestone Dec 27, 2024
@whzruc whzruc self-assigned this Dec 27, 2024
@bianhq bianhq changed the title fix duckdb benchmark_runner bugs [CPP] fix duckdb benchmark_runner bugs Dec 30, 2024
@bianhq bianhq changed the title [CPP] fix duckdb benchmark_runner bugs [cpp] fix duckdb benchmark_runner bugs Dec 30, 2024
@whzruc
Copy link
Collaborator Author

whzruc commented Jan 3, 2025

The reason for this bug is that the implementation of the String type in pixels-cpp is incorrect. I also tested other types. The results are shown as follows.

  • string(varchar)
    image
  • Select *
    image
  • BufferPool?

image
I think the work is not easy,may need to rewrite some of the pixels-cpp

@whzruc whzruc linked a pull request Jan 9, 2025 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant