Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add network placeholders that show data from the whole network #2267

Closed
ILikeOrangeJuice opened this issue Feb 5, 2022 · 2 comments
Closed
Labels
New Feature Issues that are about new features Placeholders Issues related to PlaceholderAPI

Comments

@ILikeOrangeJuice
Copy link

ILikeOrangeJuice commented Feb 5, 2022

I would like to be able to..

See top playtime placeholder values on the network level instead of server

Is your feature request related to a problem? Please describe.

Both placeholders to be the same value.

As discussed in discord, I include the images as well, maybe it helps you more when u see the different values.
In short, the top values r different than the ones by the players personal ones which it shouldn't be.
total1:
https://prnt.sc/26ow6jz
monthly:
https://prnt.sc/26owbla
weekly:
https://prnt.sc/26owc88
daily:
https://prnt.sc/26owcxo
personal:
https://prnt.sc/26owd4s

@ILikeOrangeJuice ILikeOrangeJuice added the Bug Issues that contain unintended behavior label Feb 5, 2022
@AuroraLS3 AuroraLS3 added this to Backlog Feb 5, 2022
@AuroraLS3 AuroraLS3 moved this to INBOX in Backlog Feb 5, 2022
@AuroraLS3 AuroraLS3 added Placeholders Issues related to PlaceholderAPI DEV release Issues that are related to a DEV version and not present in previous Release version labels Feb 5, 2022
@AuroraLS3 AuroraLS3 changed the title Placeholder query bug Playtime top and personal playtime placeholders report different values Feb 7, 2022
@AuroraLS3 AuroraLS3 removed the Bug Issues that contain unintended behavior label Feb 11, 2022
@AuroraLS3 AuroraLS3 changed the title Playtime top and personal playtime placeholders report different values Add network placeholders that show data from the whole network Feb 11, 2022
@AuroraLS3 AuroraLS3 added New Feature Issues that are about new features and removed DEV release Issues that are related to a DEV version and not present in previous Release version labels Feb 11, 2022
@AuroraLS3 AuroraLS3 moved this from INBOX to Needs Refinement in Backlog Apr 7, 2022
@ILikeOrangeJuice
Copy link
Author

Hey! :)

I saw you added new playtime placeholders in a fresh issue, so I thought I ask about this one here.
Is there any progress on this one yet?
I know you've been busy with irl and the frontend rework, so I never asked and just waited, but by now I am curious if there are any updates regarding this or if it is eventually already possible.

Best regards ^-^

@AuroraLS3
Copy link
Collaborator

I looked at this but since it was a lot larger than a few lines of code I had to skip it (Since I only had time for small changes)

I figured out a way to do this though - A lot of the queries use WHERE server_uuid=$1 so I'll be able to change it to WHERE $1 IS NULL OR server_uuid=$1 to have data for all servers take into account without duplicating every query

@AuroraLS3 AuroraLS3 added this to the Large network -support milestone Jan 25, 2023
@AuroraLS3 AuroraLS3 moved this from Needs Refinement to Assigned to Milestone in Backlog Jan 25, 2023
@github-project-automation github-project-automation bot moved this from Assigned to Milestone to Done in Backlog Jan 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
New Feature Issues that are about new features Placeholders Issues related to PlaceholderAPI
Projects
Status: Done
Development

No branches or pull requests

2 participants