Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fixed: add astunparser to python<3.9 wheel #604

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fixed: add astunparser to python<3.9 wheel #604

merged 1 commit into from
Apr 25, 2023

Conversation

victorbadenas
Copy link
Contributor

@victorbadenas victorbadenas commented Apr 25, 2023

In setup.py, sys.version_info.minor only returns the minor part of the version info. This check was never True and the wheel did not contain the extra dependency for python versions < 3.9.

Solves #603

After the fix, building the wheel locally with python 3.8:

$ make sdist
$ unzip dist/scalene-1.5.21.2-cp38-cp38-linux_x86_64.whl -d dist
$ cat dist/scalene-1.5.21.2.dist-info/METADATA | grep astunparse
Requires-Dist: astunparse (>=1.6.3)

@emeryberger emeryberger merged commit cce5968 into plasma-umass:master Apr 25, 2023
@victorbadenas victorbadenas deleted the fix/python_less_3.9_astunparse_dep branch April 25, 2023 15:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants