Updates to properly handle @profile decorators for CPU time attribution #637
Conversation
|
@sternj We could use a test for |
emeryberger
changed the title
|
This seems like it does the right thing to me, I'm going to put in a test that tests the statement "Given an @Profile decorator on a single function, there is precisely one function in the 'functions' field of the output and it has the name of that function" |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,65 @@ | |||
| #!/usr/bin/env python3 | |||
| import numpy as np | |||
Check notice
Code scanning / CodeQL
Unused import
| y = 1 | ||
| # w, v = LA.eig(np.diag(arr)) # (1, 2, 3, 4, 5, 6, 7, 8, 9, 10))) | ||
| x = [i*i for i in range(0,100000)][99999] | ||
| y1 = [i*i for i in range(0,200000)][199999] |
Check notice
Code scanning / CodeQL
Unused local variable
| # w, v = LA.eig(np.diag(arr)) # (1, 2, 3, 4, 5, 6, 7, 8, 9, 10))) | ||
| x = [i*i for i in range(0,100000)][99999] | ||
| y1 = [i*i for i in range(0,200000)][199999] | ||
| z1 = [i for i in range(0,300000)][299999] |
Check notice
Code scanning / CodeQL
Unused local variable
|
Smoketest is currently failing… |
| x = 1.01 | ||
| return x | ||
|
|
||
| import sys |
Check notice
Code scanning / CodeQL
Unused import
| # z = np.multiply(x,x) | ||
| # z = np.multiply(z,z) | ||
| # z = np.multiply(z,z) | ||
| z = z * z |
Check warning
Code scanning / CodeQL
Variable defined multiple times
| @profile | ||
| def doit3(x): | ||
| for i in range(1000000): | ||
| z = x + 1 |
Check warning
Code scanning / CodeQL
Variable defined multiple times
| def doit3(x): | ||
| for i in range(1000000): | ||
| z = x + 1 | ||
| z = x + 1 |
Check warning
Code scanning / CodeQL
Variable defined multiple times
| for j in range(1,3): | ||
| x = doit1(x) | ||
| x = doit2(x) | ||
| x = doit3(x) |
Check warning
Code scanning / CodeQL
Variable defined multiple times
Fixes to restore the
@profiledecorator to its intended semantics (if any code has a@profiledecorator, only profile that code).