Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix InputElement#blurOnEscape #313

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Fix InputElement#blurOnEscape #313

merged 1 commit into from
Apr 30, 2023

Conversation

willeastcott
Copy link
Contributor

Looks like a copy and paste error.

@willeastcott willeastcott added the bug Something isn't working label Apr 30, 2023
@willeastcott willeastcott self-assigned this Apr 30, 2023
@willeastcott willeastcott merged commit 71a923d into main Apr 30, 2023
@willeastcott willeastcott deleted the fix-bluronescape branch April 30, 2023 11:36
@slimbuck
Copy link
Member

Might fix playcanvas/editor#1008 ?

@willeastcott
Copy link
Contributor Author

willeastcott commented Apr 30, 2023

It's possible. But I'm almost certain it fixes the chat widget, where when you hit enter, the text input element loses focus, despite being declared like this:

    const input = new TextInput({
        blurOnEnter: false,
        keyChange: true,
        placeholder: '>'
    });

This bug surfaced after I ported the chat widget to PCUI a few months back.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants