Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix jsdoc for placeholder #334

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix jsdoc for placeholder #334

wants to merge 3 commits into from

Conversation

slimbuck
Copy link
Member

Placeholders are also used for vector inputs, which take string[].

@slimbuck slimbuck added the bug Something isn't working label Nov 14, 2023
@slimbuck slimbuck requested a review from a team November 14, 2023 12:23
@slimbuck slimbuck self-assigned this Nov 14, 2023
willeastcott
willeastcott previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an old PR, @slimbuck, but it LGTM. Happy for me to merge?

@willeastcott
Copy link
Contributor

willeastcott commented Apr 30, 2024 •
edited
Loading

Oh wait, I see the problem now. It's not building. For VectorInput, it's really just a wrapper for a number of InputElements. I'm wondering if we just don't make VectorInput inherit from IPlaceholder instead? This is instead of updating several other classes to handle string[] properly.

@willeastcott willeastcott dismissed their stale review April 30, 2024 19:14

PR not yet ready.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

@willeastcott willeastcott willeastcott left review comments

Assignees

@slimbuck slimbuck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slimbuck @willeastcott @mvaligursky