Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove patch of _delObj on PluggableAuthSerive #9

Open
jensens opened this issue Mar 10, 2015 · 2 comments
Open

Remove patch of _delObj on PluggableAuthSerive #9

jensens opened this issue Mar 10, 2015 · 2 comments

Comments

@jensens
Copy link
Member

jensens commented Mar 10, 2015

In code pas.py there was already a comment, no more to say:

# for ZopeVersionControl, we need to check 'plugins' for more than
# existence, since it replaces objects (like 'plugins') with SimpleItems
# and calls _delOb, which tries to use special methods of 'plugins'
def _delOb(self, id):
    #
    #   Override ObjectManager's version to clean up any plugin
    #   registrations for the deleted object
    #
    # XXX imo this is a evil one
    #
@gforcada
Copy link
Member

And actually you were the one adding that "XXX imo this is a evil one": d4ed704

@jensens
Copy link
Member Author

jensens commented Mar 10, 2015

yeah indeed, but the above information is more interesting

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants