Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not update buildout.coredev on PRs that have a [ci-skip] message #138

Closed
gforcada opened this issue May 31, 2023 · 1 comment
Closed

Comments

@gforcada
Copy link
Member

As @mauritsvanrees found out, we are only partially following the [ci-skip] message when merging a PR.

Either we check for [ci-skip] before firing the MergedPullRequest event (on these lines) or we rather do it on the event subscriber (on these class).

The second feels more natural, as there are plenty of checks there already.

We might even recycle some of the logic on the direct commits case ♻️

🍀

@gforcada
Copy link
Member Author

gforcada commented Jun 2, 2023

Finally, after a few tries and back and forth, plone/plone.registry#28 was merged with a [ci-skip] message on the PR commit message and mr.roboto did not update buildout.coredev 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant