You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Finally, after a few tries and back and forth, plone/plone.registry#28 was merged with a [ci-skip] message on the PR commit message and mr.roboto did not update buildout.coredev 🎉
As @mauritsvanrees found out, we are only partially following the
[ci-skip]
message when merging a PR.Either we check for
[ci-skip]
before firing theMergedPullRequest
event (on these lines) or we rather do it on the event subscriber (on these class).The second feels more natural, as there are plenty of checks there already.
We might even recycle some of the logic on the direct commits case ♻️
🍀
The text was updated successfully, but these errors were encountered: