Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Dash dev tools poor contrast with dark themes #1649

Closed
vikigenius opened this issue May 21, 2021 · 3 comments · Fixed by #1664
Closed

[BUG] Dash dev tools poor contrast with dark themes #1649

vikigenius opened this issue May 21, 2021 · 3 comments · Fixed by #1664
Labels
bug something broken

Comments

@vikigenius
Copy link

Describe your context
Please provide us your environment, so we can easily reproduce the issue.

  • replace the result of pip list | grep dash below
dash                          1.20.0
dash-bootstrap-components     0.12.2
dash-core-components          1.16.0
dash-html-components          1.1.3
dash-renderer                 1.9.1
dash-table                    4.11.3
  • if frontend related, tell us your Browser, Version and OS

    • OS: Linux
    • Browser: Firefox
    • Version: 88.0

Describe the bug
When using a dark theme, the DEV tools menus when showing errors has very poor contrast.

Expected behavior
The debug menus should still be properly visible when using dark themes.

Screenshots

scrot_20210516_142357

@alexcjohnson
Copy link
Collaborator

Thanks @vikigenius - looks like we just need to reset font colors within the devtools (including the little bubble at the bottom that's supposed to show the error count). I don't think it's worth trying to theme the devtools themselves, would you agree?

@alexcjohnson alexcjohnson added the bug something broken label May 21, 2021
@vikigenius
Copy link
Author

Yeah, i think that makes sense. @tcbegley what do you think? Would that work?

@tcbegley
Copy link
Contributor

Yeah, I was thinking you'd just set color: black or something. Since it's just for development there's no need for anything fancier.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug something broken
Projects
None yet
3 participants