Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

special handling for _reload-hash in dev tools #920

Closed
chriddyp opened this issue Sep 10, 2019 · 6 comments · Fixed by #1237
Closed

special handling for _reload-hash in dev tools #920

chriddyp opened this issue Sep 10, 2019 · 6 comments · Fixed by #1237
Assignees

Comments

@chriddyp
Copy link
Member

when my app crashes, the reload request fails. this causes repeated error message in dash dev tools:
image

It would be nice if we could treat this message with more care:

  • Only display the error once or twice
  • Update the error message to be something like "The app has likely crashed."
@alexcjohnson
Copy link
Collaborator

Good call - also if you forget and leave a dash app open in a tab after halting its server... next day the whole browser starts dragging as those thousands of calls clog up the page.

@raghavendrajain
Copy link

Hi. In my case, even when there is NO error in the code, page displays this error whenever a change is made. I think, it is a problem with hot-reloading feature, as it appears irrespective of whether code is correct or wrong.

@alexcjohnson
Copy link
Collaborator

@raghavendrajain that's not an issue I've seen, can you say more? Does it happen with any app or just a specific one? What versions of Dash packages do you have? (pip list | grep dash if installed by pip)

@kenhui521
Copy link

@alexcjohnson
I got the same error as well. It's not to an app specific. My dash version is dash==1.2.0.
I have noticed that this error appeared when there is a long running method executed by dash button.

@alexcjohnson
Copy link
Collaborator

Thanks @kenhui521 - I've tried creating extremely slow callbacks, clogging the server, and still haven't been able to generate that error. If you're able to find an app simple enough to share that I can use to replicate this error, I'd love to see it!

@alexcjohnson
Copy link
Collaborator

Perhaps we should convert this situation from an error to a simple status indicator - when the most recent _reload-hash request failed, we add a little red light somewhere that has a tooltip saying "the back end is not responding" - and when a request succeeds we remove that indicator.

Also perhaps we should skip these requests entirely - or at least make them much less frequent - when the window is inactive (document.visibilityState !== 'visible' is what I used in dash-notes) - just means it may have the old state for a couple seconds when you come back to it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants