Skip to content

Uncaught error when user zoom (by mouse) or click on graph layer #2438

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
skyandrd opened this issue Mar 5, 2018 · 7 comments
Closed

Uncaught error when user zoom (by mouse) or click on graph layer #2438

skyandrd opened this issue Mar 5, 2018 · 7 comments

Comments

@skyandrd
Copy link

skyandrd commented Mar 5, 2018

Hello. A bug can be reproduced here https://codepen.io/skyandrd/pen/oERddp

When I click (or double click) on the graphics or select it with the mouse to zoom in, the browser console displays an error:
index.html:1 Uncaught (in promise) undefined
Promise.then (async)
update @ plotly-latest.js:127424

@etpinard
Copy link
Contributor

etpinard commented Mar 5, 2018

Hmm. I can't reproduce.

Could you share a videocast of the interactions that induce the uncaught error(s) to help us out?

@alexcjohnson
Copy link
Collaborator

I see that error - draw a zoombox and hold it for a couple of seconds, such that a few of these Plotly.update calls happen from the setTimeout. It's an intentional Promise.reject here added way back in #226. We bail out of redrawing the plot at that point because there's an interaction ongoing, and I guess the returned Promise is rejected as a signal to the user that this happened. It's not clear to me that this is a problem though, or if it is a problem what the solution should look like.

@iMaximal
Copy link

iMaximal commented Mar 6, 2018

Same problem :-(

@skyandrd
Copy link
Author

skyandrd commented Mar 6, 2018

@etpinard The screencast is attached here

@etpinard
Copy link
Contributor

etpinard commented Mar 6, 2018

Related #2382

@david-polak
Copy link

This issue is still relevant screencast

@etpinard
Copy link
Contributor

etpinard commented Dec 3, 2018

Merged into #3305

@etpinard etpinard closed this as completed Dec 3, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants