Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace old image test system with Kaleido #5625

Closed
archmoj opened this issue May 4, 2021 · 1 comment · Fixed by #5724
Closed

Replace old image test system with Kaleido #5625

archmoj opened this issue May 4, 2021 · 1 comment · Fixed by #5724
Milestone

Comments

@archmoj
Copy link
Contributor

archmoj commented May 4, 2021

Old image test uses a very old Chrome version.
Several bugs including this frustrating sort bug https://twitter.com/mathias/status/1036626116654637057?lang=en had been fixed sice then.
With depreciation of Plotly.plot method we also use this hack d688bba
And there are issues around using MathJax v2.7.5 with old image test that we were unable to render MathJax on CircleCI.

Perhaps it time to try Kaleido.

@archmoj
Copy link
Contributor Author

archmoj commented Jun 1, 2021

@antoinerg 's note regarding certain environment variables that may be useful in this regard:
https://github.com/plotly/orca/blob/c68d3dfa7f293bc3035288dfc2941b4a7532ee14/test/image/render_mocks_cli#L22-L24

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant