Fixed deprecated usage of v8::String::Value constructor

Roland Eischer · Roland Eischer · commit 8de80ef02cec · 2018-10-01T13:56:38.000+02:00
- v8 has declared the usage of the v8::String::Value constructor without isolate parameter as deprecated therefore add already available isolate as parameter
diff --git a/v8pp/convert.hpp b/v8pp/convert.hpp
@@ -73,12 +73,12 @@ struct convert<std::basic_string<Char, Traits, Alloc>>
 
 		if (sizeof(Char) == 1)
 		{
-			v8::String::Utf8Value const str(value);
+			v8::String::Utf8Value const str(isolate, value);
 			return from_type(reinterpret_cast<Char const*>(*str), str.length());
 		}
 		else
 		{
-			v8::String::Value const str(value);
+			v8::String::Value const str(isolate, value);
 			return from_type(reinterpret_cast<Char const*>(*str), str.length());
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -73,12 +73,12 @@ struct convert<std::basic_string<Char, Traits, Alloc>>`
`73`	`73`
`74`	`74`	`if (sizeof(Char) == 1)`
`75`	`75`	`{`
`76`		`- v8::String::Utf8Value const str(value);`
	`76`	`+ v8::String::Utf8Value const str(isolate, value);`
`77`	`77`	`return from_type(reinterpret_cast<Char const>(str), str.length());`
`78`	`78`	`}`
`79`	`79`	`else`
`80`	`80`	`{`
`81`		`- v8::String::Value const str(value);`
	`81`	`+ v8::String::Value const str(isolate, value);`
`82`	`82`	`return from_type(reinterpret_cast<Char const>(str), str.length());`
`83`	`83`	`}`
`84`	`84`	`}`