Fixed deprecated usage of v8::String::Value constructor

Roland Eischer · Roland Eischer · commit b808c7635178 · 2018-09-07T09:38:27.000+02:00
- v8 has declared the usage of the v8::String::Value constructor without isolate parameter as deprecated therefore add already available isolate as parameter
diff --git a/v8pp/convert.hpp b/v8pp/convert.hpp
@@ -68,12 +68,12 @@ struct convert<std::basic_string<Char, Traits, Alloc>>
 
 		if (sizeof(Char) == 1)
 		{
-			v8::String::Utf8Value const str(value);
+			v8::String::Utf8Value const str(isolate, value);
 			return from_type(reinterpret_cast<Char const*>(*str), str.length());
 		}
 		else
 		{
-			v8::String::Value const str(value);
+			v8::String::Value const str(isolate, value);
 			return from_type(reinterpret_cast<Char const*>(*str), str.length());
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -68,12 +68,12 @@ struct convert<std::basic_string<Char, Traits, Alloc>>`
`68`	`68`
`69`	`69`	`if (sizeof(Char) == 1)`
`70`	`70`	`{`
`71`		`- v8::String::Utf8Value const str(value);`
	`71`	`+ v8::String::Utf8Value const str(isolate, value);`
`72`	`72`	`return from_type(reinterpret_cast<Char const>(str), str.length());`
`73`	`73`	`}`
`74`	`74`	`else`
`75`	`75`	`{`
`76`		`- v8::String::Value const str(value);`
	`76`	`+ v8::String::Value const str(isolate, value);`
`77`	`77`	`return from_type(reinterpret_cast<Char const>(str), str.length());`
`78`	`78`	`}`
`79`	`79`	`}`