Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add first ugly support for std::function overload for v8pp::convert #169

Closed

Conversation

YarikTH
Copy link
Contributor

@YarikTH YarikTH commented Aug 10, 2021

  • Need to add tests
  • Fix forward declaration of wrap_function (Template parameter redefines default argument in "typename Traits = raw_ptr_traits")
  • Make sure function converter is composable with other converters (std::function<void(std::vector)>, std::vector<std::function<void()>> etc)
  • Fix problem that caller should additionally include v8pp/call_v8.hpp or template call_v8 would be illformed

Closes #142

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support std::function as function parameter
1 participant