Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Idea] Stories should be written in TS #220

Closed
joshuaellis opened this issue Jan 8, 2021 · 5 comments · Fixed by #223
Closed

[Idea] Stories should be written in TS #220

joshuaellis opened this issue Jan 8, 2021 · 5 comments · Fixed by #223
Assignees
Labels
enhancement New feature or request

Comments

@joshuaellis
Copy link
Member

I just saw #219 and realised if the stories were written in TS then this issue probably wouldn't have happened. I'm happy to work on this if you want to make the move, it's a bit of a chore, but in the long run it'd probably be useful (especially when making new components).

@gsimone
Copy link
Member

gsimone commented Jan 8, 2021

Absolutely, it's a lot of work, but if you or somebody can start, I'll be glad to help

@gsimone
Copy link
Member

gsimone commented Jan 8, 2021

Also kinda related, stories right now import from the component, ideally they should import from src/index to give us an early error if we forgetti spaghetti exports

@joshuaellis
Copy link
Member Author

ideally they should import from src/index to give us an early error if we forgetti spaghetti exports
Yes good point, might as well do that here too.

On the subject of exports, is it worth sorting out the export pattern because people keep having issues with react-native

I thought you could potentially have @react-three/drei/native and not include Html, maybe make a native Loader. I can make a new issue if you prefer.

@gsimone
Copy link
Member

gsimone commented Jan 8, 2021

yeah, do open an issue for that, making an ad-hoc export for native makes sense, let's see what others suggest

@joshuaellis joshuaellis self-assigned this Jan 12, 2021
@joshuaellis joshuaellis added the enhancement New feature or request label Jan 12, 2021
@joshuaellis
Copy link
Member Author

fixed in #231

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants