Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add missing Text component type definition #2237

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

whatisjery
Copy link
Contributor

@whatisjery whatisjery commented Nov 28, 2024

Why

Missing TypeScript type for prop that controls the number of vertical/horizontal segments in each glyph's plane

What

Added type definition for glyphGeometryDetail
Reference: https://protectwise.github.io/troika/troika-three-text/#glyphgeometrydetail

Checklist

  • Ready to be merged

Copy link

vercel bot commented Nov 28, 2024

@whatisjery is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codesandbox-ci bot commented Nov 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@whatisjery whatisjery changed the title chore: add missing Text component type definition fix: add missing Text component type definition Nov 28, 2024
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 0:52am

@CodyJasonBennett CodyJasonBennett merged commit 1d62184 into pmndrs:master Jan 15, 2025
4 checks passed
Copy link

🎉 This PR is included in version 9.120.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants