Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(core): remove unnecessary code #2966

Closed
wants to merge 2 commits into from

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Feb 1, 2025

With #2965, L483 is no longer necessary. I should have noticed when reviewing.

Now, I wonder if we can write a failing test for this. It's probably unlikely.

Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 11:23pm

Copy link

codesandbox-ci bot commented Feb 1, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Feb 1, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2966

commit: 6776a4d

Copy link

github-actions bot commented Feb 1, 2025

Size Change: -7 B (-0.01%)

Total Size: 92.3 kB

Filename Size Change
./dist/esm/vanilla.mjs 4.26 kB +9 B (+0.21%)
./dist/system/vanilla.development.js 4.35 kB +4 B (+0.09%)
./dist/system/vanilla.production.js 2.21 kB -15 B (-0.68%)
./dist/umd/vanilla.development.js 5.74 kB +2 B (+0.03%)
./dist/umd/vanilla.production.js 2.86 kB -14 B (-0.49%)
./dist/vanilla.js 5.62 kB +7 B (+0.12%)
ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 933 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.2 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react.mjs 1.41 kB
./dist/esm/react/utils.mjs 747 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla/utils.mjs 5.05 kB
./dist/index.js 242 B
./dist/react.js 1.44 kB
./dist/react/utils.js 1.39 kB
./dist/system/babel/plugin-debug-label.development.js 1.11 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.3 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react.development.js 1.56 kB
./dist/system/react.production.js 865 B
./dist/system/react/utils.development.js 859 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla/utils.development.js 5.26 kB
./dist/system/vanilla/utils.production.js 3.15 kB
./dist/umd/babel/plugin-debug-label.development.js 1.07 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react.development.js 1.56 kB
./dist/umd/react.production.js 936 B
./dist/umd/react/utils.development.js 1.53 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla/utils.development.js 6.25 kB
./dist/umd/vanilla/utils.production.js 3.78 kB
./dist/utils.js 247 B
./dist/vanilla/utils.js 6.11 kB

compressed-size-action

Copy link

github-actions bot commented Feb 1, 2025

LiveCodes Preview in LiveCodes

Latest commit: 6776a4d
Last updated: Feb 1, 2025 11:23pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/87VECLJF5

See documentations for usage instructions.

@dai-shi
Copy link
Member Author

dai-shi commented Feb 12, 2025

This is included in #2911.

@dai-shi dai-shi closed this Feb 12, 2025
@dai-shi dai-shi deleted the refactor/store/unnecessary-changed-atoms-set branch February 12, 2025 00:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant