Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

wrong type in defaultColor in OutlineEffect #379

Open
igpdev-428 opened this issue Oct 3, 2024 · 0 comments
Open

wrong type in defaultColor in OutlineEffect #379

igpdev-428 opened this issue Oct 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@igpdev-428
Copy link

  • three version: 0.150.1
  • @types/three version: 0.163
  • three-stdlib version: 2.33.0

Problem description:

defaultColor in OutlineEffectParameters for the OutlineEffect class is set to number[]. It should probably be Color

Relevant code:

export interface OutlineEffectParameters {
defaultThickness?: number | undefined
defaultColor?: number[] | undefined
defaultAlpha?: number | undefined
defaultKeepAlive?: boolean | undefined
}

Suggested solution:

Change it to be Color type.
Thank you for providing this library for us developers.

@igpdev-428 igpdev-428 added the bug Something isn't working label Oct 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant