Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

type errors on addEventListener for any class that extends from EventDispatcher #387

Open
RodrigoHamuy opened this issue Nov 28, 2024 · 0 comments · Fixed by #388
Open
Labels
bug Something isn't working

Comments

@RodrigoHamuy
Copy link
Contributor

RodrigoHamuy commented Nov 28, 2024

  • @types/three version: from 0.168.0
  • three-stdlib version: 2.34.0

Problem description:

@types/three introduced on v168 the breaking change that unknown events can no longer be dispatched in EventDispatcher (source).

Relevant code:

So now this will throw TS errors:

import { OrbitControls } from "three-stdlib";

const orbit = new OrbitControls();

orbit.addEventListener("start", ()=> console.log('started'));
// Argument of type 'string' is not assignable to parameter of type 'never'.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant