Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for new battle move segments #1031

Open
Pronyo-Chan opened this issue Apr 25, 2023 · 0 comments
Open

Add support for new battle move segments #1031

Pronyo-Chan opened this issue Apr 25, 2023 · 0 comments

Comments

@Pronyo-Chan
Copy link

I'm trying to add a new battle move and each one of them is defined as its own segment in splat.yaml.
Example of a vanilla move:

- name: battle_move_hammer_attack
    dir: battle/move/hammer
    type: code
    start: 0x7345A0
    vram: 0x802A1000
    follows_vram: battle_code
    subsegments:
    - [0x7345A0, c, attack]
    - [0x734650]

I tried adding it under the basic hammer attack segment like so:

- name: battle_move_fire_attack
    dir: battle/move/fire
    type: code
    subsegments:
    - [auto, c, attack]
    - [auto]

and get the following error: no segment rom overlaps symbol battle_move_hammer_IsBerserkerEquipped. I tried also specifying the vram/ follows vram, setting start to auto, but I always end up with the same error. Ethan is pretty sure it's just not supported yet, here's a link to the discord discussion: https://discord.com/channels/279322074412089344/989948270954565772/1100558313885814854

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant