Enhancement: spo site set enhance logo options

[Jwaegebaert]

Right now, when you use siteLogoUrl in the spo site set command, it changes the thumbnail, not the actual logo of the site. Looking at the command's inner workings, it seems the body sent to _api/siteiconmanager/setsitelogo is missing a few things. With some tweaks to this endpoint, we should be able to modify the thumbnail and the logo as well. Let's add another option and adjust the command a bit.

Option	Description
--siteThumbnailUrl [siteThumbnailUrl]	Set the thumbnail for the site collection. This can be an absolute or relative URL to a file on the current site collection.

The request options for _api/siteiconmanager/setsitelogo should look like this:

• To update the thumbnail:

const requestOptions: CliRequestOptions = {
  url: `${args.options.url}/_api/siteiconmanager/setsitelogo`,
  headers: {
    accept: 'application/json;odata=nometadata'
  },
  data: {
    aspect: 0,
    relativeLogoUrl: thumbnailUrl,
    type: 0
  },
  responseType: 'json'
};

• To update the logo:

const requestOptions: CliRequestOptions = {
  url: `${args.options.url}/_api/siteiconmanager/setsitelogo`,
  headers: {
    accept: 'application/json;odata=nometadata'
  },
  data: {
    aspect: 1,
    relativeLogoUrl: logoUrl,
    type: 0
  },
  responseType: 'json'
};

[Adam-it]

So just to confirm it the only difference is the aspect 🙂? But is it actually that we have it defined twice in the data 🤔?
Let's not show an example using any but instead let's use CliRequestOptions .

[Jwaegebaert]

I don't know why but aspect is the golden property to differentiate a logo from thumbnail and regular logo

[Adam-it]

I don't know why but aspect is the golden property to differentiate a logo from thumbnail and regular logo

ok but now we have it twice:

data: {
    aspect: 1,
    relativeLogoUrl: logoUrl,
    aspect: 0
  },

won't this work?

data: {
    aspect: 1,
    relativeLogoUrl: logoUrl,
  },

other than that seems ok and lets open it up for hacktoberfest 👍

[Jwaegebaert]

My bad, the last param shouldn't be aspect but is type. I updated the specs.

[Adam-it]

My bad, the last param shouldn't be aspect but is type. I updated the specs.

No problem. Seems legit now 👍.
Let's open this up. Thank you @Jwaegebaert for the awesome suggestion 👍

[reshmee011]

please assign to me to attempt implementing it.

[milanholemans]

All yours @reshmee011 💪