Merge pull request #3152 from gautamdsheth/feature/2922

Feature #2922: added pagination for Add-PnPDataRowsToSiteTemplate cmdlet

Author: gautamdsheth

CHANGELOG.md

@@ -48,6 +48,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Improved `Set-PnPHomePage` cmdlet to handle forward slash issue. [#3128](https://github.com/pnp/powershell/pull/3128)
 - Improved `Connect-PnPOnline` cmdlet to handle ping on the destination server to check if it exists. [PR](https://github.com/pnp/powershell/commit/cc3c5564fca9ce96b1a2ac47c7aabdc8b90136d0) and [#3154](https://github.com/pnp/powershell/pull/3154)
 - Improved `Invoke-PnPGraphMethod` cmdlet to show a better error message when sufficient permissions are not available. [#3133](https://github.com/pnp/powershell/pull/3133)
+- Improved `Add-PnPDataRowsToSiteTemplate` cmdlet to retrieve list item with pagination. [#3152](https://github.com/pnp/powershell/pull/3152)
 
 ### Removed
 

src/Commands/Provisioning/Site/AddDataRowsToSiteTemplate.cs

@@ -46,7 +46,7 @@ public class AddDataRowsToSiteTemplate : PnPWebCmdlet
 
         [Parameter(Mandatory = false)]
         [ValidateNotNullOrEmpty]
-        public string KeyColumn;
+        public string KeyColumn;        
 
         private readonly static FieldType[] _unsupportedFieldTypes =
         {
@@ -104,11 +104,21 @@ protected override void ExecuteCmdlet()
                 viewFieldsStringBuilder.Append("</ViewFields>");
             }
 
-            query.ViewXml = string.Format("<View>{0}{1}</View>", Query, viewFieldsStringBuilder);
-            var listItems = spList.GetItems(query);
+            query.ViewXml = string.Format("<View Scope='RecursiveAll'>{0}{1}</View>", Query, viewFieldsStringBuilder);
+            List<ListItem> listItems = new List<ListItem>();
+            do
+            {
+                var listItemsCollection = spList.GetItems(query);
 
-            ClientContext.Load(listItems, lI => lI.Include(l => l.HasUniqueRoleAssignments, l => l.ContentType.StringId));
-            ClientContext.ExecuteQueryRetry();
+                ClientContext.Load(listItemsCollection, lI => lI.Include(l => l.HasUniqueRoleAssignments, l => l.ContentType.StringId));
+                ClientContext.ExecuteQueryRetry();
+
+                listItemsCollection.EnsureProperty(l => l.ListItemCollectionPosition);
+
+                query.ListItemCollectionPosition = listItemsCollection.ListItemCollectionPosition;
+                listItems.AddRange(listItemsCollection);
+
+            } while (query.ListItemCollectionPosition != null);            
 
             Microsoft.SharePoint.Client.FieldCollection fieldCollection = spList.Fields;
             ClientContext.Load(fieldCollection, fs => fs.Include(f => f.InternalName, f => f.FieldTypeKind, f => f.ReadOnlyField));