Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Doesn't work with pnpm v7 #28

Closed
zkochan opened this issue Feb 2, 2022 · 2 comments
Closed

Doesn't work with pnpm v7 #28

zkochan opened this issue Feb 2, 2022 · 2 comments

Comments

@zkochan
Copy link
Member

zkochan commented Feb 2, 2022

I just release pnpm v7.0.0-alpha.0 and for some reason it doesn't work with this action. Looks like it doesn't appear in the PATH. Might be related to this: pnpm/pnpm#4280

@KSXGitHub
Copy link
Collaborator

This action only calls the self installer provided by pnpm:

export async function runSelfInstaller(inputs: Inputs): Promise<number> {
const { version, dest } = inputs
const target = version ? `pnpm@${version}` : 'pnpm'
const pkgJson = join(dest, 'package.json')
await remove(dest)
await ensureFile(pkgJson)
await writeFile(pkgJson, JSON.stringify({ private: true }))
const cp = spawn(execPath, ['-', 'install', target, '--no-lockfile'], {
cwd: dest,
stdio: ['pipe', 'inherit', 'inherit'],
})
const response = await fetch('https://pnpm.js.org/pnpm.js')
response.body.pipe(cp.stdin)
return new Promise((resolve, reject) => {
cp.on('error', reject)
cp.on('close', resolve)
})
}

@zkochan
Copy link
Member Author

zkochan commented Feb 8, 2022

Fixed in v2.1.0 via #29

@zkochan zkochan closed this as completed Feb 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants