Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Respect join_null argument for semi/anti joins #15696

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Apr 16, 2024

fixes #15685

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 16, 2024
Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #15696 will not alter performance

Comparing join_nulls (26eb756) with main (8befcd1)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 96.36364% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.34%. Comparing base (8befcd1) to head (26eb756).

Files Patch % Lines
...s/src/frame/join/hash_join/single_keys_dispatch.rs 87.50% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15696   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files        1375     1375           
  Lines      176532   176558   +26     
  Branches     2544     2544           
=======================================
+ Hits       143604   143627   +23     
- Misses      32445    32450    +5     
+ Partials      483      481    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ee660ee into main Apr 16, 2024
26 checks passed
@ritchie46 ritchie46 deleted the join_nulls branch April 16, 2024 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

join_nulls has no effect when how="semi"
1 participant