-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: raise if index count like 2i is used when performing rolling, group_by_dynamic, upsample, or other temporal operatios #15751
Conversation
@pytest.mark.parametrize( | ||
("every", "match"), | ||
[ | ||
("-1i", r"'every' argument must be positive"), | ||
( | ||
"2h", | ||
r"you cannot combine time durations like '2h' with integer durations like '3i'", | ||
), | ||
], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two errors are completely different, I've moved the second one out into a separate test below
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15751 +/- ##
=======================================
Coverage 81.35% 81.35%
=======================================
Files 1379 1379
Lines 176619 176613 -6
Branches 2544 2544
=======================================
+ Hits 143686 143688 +2
+ Misses 32449 32442 -7
+ Partials 484 483 -1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #15751 will not alter performanceComparing Summary
|
…oup_by_dynamic, upsample, or other temporal operation on datetime column
6173e48
to
fff4334
Compare
closes #15749