chore(python): Start at using new Bound<> API from PyO3 #15752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
itamarst
commented
Apr 18, 2024
itamarst
commented
Apr 18, 2024
| "timedelta" => get_timedelta, | ||
| "Decimal" => get_decimal, | ||
| "range" => get_list, | ||
| "date" => get_date as InitFn, |
There was a problem hiding this comment.
Lacking the as InitFn I got errors about "expected fn pointer, got fn item" (or vice versa?).
There was a problem hiding this comment.
(Unresolving temporarily, just in case someone else reviews)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15752 +/- ##
==========================================
+ Coverage 81.31% 81.36% +0.04%
==========================================
Files 1373 1379 +6
Lines 176256 176719 +463
Branches 2544 2542 -2
==========================================
+ Hits 143327 143786 +459
- Misses 32447 32452 +5
+ Partials 482 481 -1 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Apr 19, 2024
ritchie46
reviewed
Apr 19, 2024
ritchie46
force-pushed
the
15669-new-bound-api-pyo3
branch
from
5da29fe to
8086043
Compare
CodSpeed Performance ReportMerging #15752 will not alter performanceComparing Summary
|
|
Thank you, that was educational. I'll finish this up today. |
itamarst
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15699
There will be more follow-up PRs, this is just a small chunk of the usages that need upgrading (although hopefully not as tricky).