Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable Black preview #4041

Closed
wants to merge 4 commits into from
Closed

Conversation

stinodego
Copy link
Contributor

black has some nice features that are currently in 'preview' mode. You can enable them by setting preview = True in the settings.

For this PR, it mostly means that long strings are wrapped automatically. It's important to note that Black is not (strongly) opinionated here, so if you prefer to wrap a line at a different point, it's possible to adjust manually.

I figured I'd just send out a PR for this, to see what the impact would be. Let me know if this is something you want! If so, I can improve some of the string wraps to be a bit nicer.

@github-actions github-actions bot added the python Related to Python Polars label Jul 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #4041 (fd615d1) into master (396018b) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4041      +/-   ##
==========================================
+ Coverage   62.82%   62.84%   +0.02%     
==========================================
  Files         449      449              
  Lines       74440    74440              
==========================================
+ Hits        46764    46779      +15     
+ Misses      27676    27661      -15     
Impacted Files Coverage Δ
py-polars/polars/exceptions.py 100.00% <ø> (ø)
py-polars/polars/internals/construction.py 97.66% <ø> (ø)
py-polars/polars/internals/expr.py 95.36% <ø> (ø)
py-polars/polars/internals/frame.py 93.43% <ø> (ø)
py-polars/polars/internals/functions.py 97.38% <ø> (ø)
py-polars/polars/internals/lazy_frame.py 76.00% <0.00%> (ø)
py-polars/polars/internals/lazy_functions.py 94.51% <ø> (ø)
py-polars/polars/internals/series.py 94.69% <ø> (ø)
py-polars/polars/io.py 67.01% <ø> (ø)
py-polars/polars/testing.py 93.40% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396018b...fd615d1. Read the comment docs.

@ritchie46
Copy link
Member

Let's wait until they get stable. This can prevent large code changes that are only caused by formatting.

@stinodego
Copy link
Contributor Author

Fair enough!

@stinodego stinodego closed this Jul 18, 2022
@stinodego stinodego deleted the black-preview branch July 18, 2022 09:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants