Fix Python line lengths to 88 characters #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
force-pushed
the
line-lengths-2
branch
3 times, most recently
from
eb30d7e to
5b9e730
Compare
stinodego
force-pushed
the
line-lengths-2
branch
from
5b9e730 to
a1270e7
Compare
|
Yeap, I think its good that we adhere to the line length we already had enforced by black. Thanks for the effort! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4044
Apologies for the mega-PR. There was a lot to fix. Fortunately it's all superficial formatting stuff, so I think it should still be reviewable.
Changes:
Misc:
inttype to theExpr.is_betweenmethod start/end args - this fixed some mypy ignores that were giving line length problemsLine length stuff is always controversial, but I think it's useful to just pick one value and stick with it!