Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add flake8-tidy-imports extension #4229

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

stinodego
Copy link
Contributor

Relates to #4044

Changes:

@github-actions github-actions bot added the python Related to Python Polars label Aug 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4229 (5caae84) into master (2dbc6bf) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4229      +/-   ##
==========================================
+ Coverage   64.09%   64.16%   +0.07%     
==========================================
  Files         458      458              
  Lines       75675    75729      +54     
==========================================
+ Hits        48502    48592      +90     
+ Misses      27173    27137      -36     
Impacted Files Coverage Δ
py-polars/polars/__init__.py 100.00% <100.00%> (ø)
py-polars/polars/internals/__init__.py 100.00% <100.00%> (ø)
py-polars/polars/internals/frame.py 91.55% <100.00%> (ø)
...ars/polars-core/src/chunked_array/ops/any_value.rs 77.39% <0.00%> (-0.87%) ⬇️
polars/polars-core/src/series/from.rs 65.00% <0.00%> (-0.59%) ⬇️
...lars/polars-core/src/chunked_array/builder/list.rs 62.29% <0.00%> (-0.28%) ⬇️
polars/polars-io/src/csv/buffer.rs 79.39% <0.00%> (-0.26%) ⬇️
.../polars-core/src/frame/groupby/aggregations/mod.rs 63.08% <0.00%> (ø)
...ars-core/src/chunked_array/ops/take/take_single.rs 44.23% <0.00%> (ø)
...lars/polars-lazy/src/physical_plan/planner/expr.rs 92.94% <0.00%> (+0.08%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbc6bf...5caae84. Read the comment docs.

@stinodego stinodego force-pushed the flake8-tidy-imports branch 2 times, most recently from 7934343 to 85ae280 Compare August 4, 2022 23:05
@ritchie46
Copy link
Member

Thanks @stinodego. There is a conflicting file and then I can merge.

@stinodego stinodego force-pushed the flake8-tidy-imports branch from 85ae280 to 8a1cf76 Compare August 6, 2022 07:04
@stinodego stinodego force-pushed the flake8-tidy-imports branch from 8a1cf76 to 91af370 Compare August 6, 2022 07:06
@stinodego
Copy link
Contributor Author

Rebased & ready to go 😎

@ritchie46 ritchie46 merged commit 1dce28b into pola-rs:master Aug 8, 2022
@stinodego stinodego deleted the flake8-tidy-imports branch August 30, 2022 18:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants