Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Force uses of django 1.8 in setup.py #150

Open
okhin opened this issue Sep 8, 2016 · 3 comments
Open

Force uses of django 1.8 in setup.py #150

okhin opened this issue Sep 8, 2016 · 3 comments
Labels

Comments

@okhin
Copy link
Contributor

okhin commented Sep 8, 2016

In setup.py, the definition for the django requirement leads setup.py to do this:

Searching for django>=1.8,<1.9
Reading https://pypi.python.org/simple/django/
Best match: Django 1.9rc1

Indeed, 1.9rc1 is prior 1.9, and basically, memopol does not works on django1.9 :)

So, maybe enforcing django==1.8 in the setup.py will help

@okhin okhin added the bug label Sep 8, 2016
@njoyard
Copy link
Member

njoyard commented Sep 11, 2016

Actually if you use pip to install it behaves correctly. I don't really know who's correct here. Semver is not very verbose on the subject ; it's clear for me that 1.9-rc1 is prior to 1.9, but if you request <1.9 you should not get 1.9-rc1.
Anyway the docs tell to use pip, that's how you get known behaviour ;)

@memopol-ci
Copy link
Member

memopol-ci commented Sep 11, 2016 via email

@njoyard
Copy link
Member

njoyard commented Sep 11, 2016

Most likely a bug in setuptools rather, pip behaves as expected.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants