Refactor: Single-Module Wrappers By Default #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrzn
reviewed
Jun 9, 2022
cbrzn
reviewed
Jun 9, 2022
cbrzn
reviewed
Jun 9, 2022
…b3-api/monorepo into namesty/888-single-mod-schema
Single Module Refactor - Schema
dOrgJelli
requested review from
namesty,
krisbitney,
nerfZael,
ramilexe and
Niraj-Kamdar
as code owners
cbrzn
reviewed
Jun 14, 2022
cbrzn
reviewed
Jun 14, 2022
cbrzn
reviewed
Jun 14, 2022
cbrzn
reviewed
Jun 14, 2022
cbrzn
reviewed
Jun 14, 2022
packages/js/core/src/__tests__/manifest/web3api/incorrect-version-format/web3api.yaml
Outdated
Show resolved
Hide resolved
packages/js/core/src/__tests__/manifest/web3api/required-field-missing/web3api.yaml
Outdated
Show resolved
Hide resolved
packages/test-cases/cases/cli/plugin/codegen/002-single-module/expected/src/w3/schema.ts
Outdated
Show resolved
Hide resolved
packages/test-cases/cases/cli/plugin/codegen/004-env-sanitization/expected/src/w3/schema.ts
Outdated
Show resolved
Hide resolved
dOrgJelli
commented
Jun 14, 2022
namesty
reviewed
Jun 15, 2022
namesty
approved these changes
Jun 15, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #886, #887, #888, #889
Features
MutationandQuerymodules has been deprecated. Now all wrapper methods are defined within a singleModule.Breaking Changes