Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat(CLI): Infra manifest support default modules #910

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

cbrzn
Copy link
Contributor

@cbrzn cbrzn commented Jun 9, 2022

This PR aims to add the capability to add a default module in the manifest, this means that we can do:

format: 0.0.1-prealpha.2
modules:
  eth-ens-ipfs: default
  mainnet-fork:
    path: ./mainnet-fork

And it will load both modules

edit: When developing this feature, I noticed that it was not possible to declare a file (i.e: my_folder/docker.compose.yaml) as a value for path in local modules, I found this weird, so I went ahead and add support to add files or folder, this way is more friendly to interact with infra :-D

so basically now this is supported:

format: 0.0.1-prealpha.2
modules:
  eth-ens-ipfs: default
  mainnet-fork:
    path: ./mainnet-fork/docker-compose.yaml
  ropsten-fork:
    path: ./ropsten-fork

@cbrzn cbrzn marked this pull request as ready for review June 9, 2022 23:28
@dOrgJelli dOrgJelli merged commit 2dca5d4 into prealpha-dev Jun 10, 2022
@cbrzn cbrzn deleted the feat/infra-manifest-support-default-modules branch June 10, 2022 20:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants