Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement reducers with handleActions #1690

Open
3 of 11 tasks
outoftime opened this issue May 18, 2019 · 0 comments
Open
3 of 11 tasks

Implement reducers with handleActions #1690

outoftime opened this issue May 18, 2019 · 0 comments

Comments

@outoftime
Copy link
Contributor

outoftime commented May 18, 2019

Currently most of our reducers are implemented as a big switch statement, which is unwieldy and hard to read. Instead, use the handleActions() helper in redux-actions to implement the reducer as a map of action names to reducer functions.

We should follow the pattern of using the action creator function itself as the map key, allowing us to avoid hard-coding string literals containing the action name.

See the console reducer for an example of the desired implementation.

Testing

Since our goal here is merely to refactor the reducers, not change their behavior, all existing tests should pass after a reducer is refactored.

However, it might make sense to also port the reducer test to Jest after completing the refactor and confirming that the old tests pass with the new reducer implementation (this should be in separate commits).

Reducers to migrate

  • clients
  • compiledProjects
  • console
  • currentProject
  • errors
  • googleClassroom
  • index
  • projects
  • resizableFlex
  • ui
  • user
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants