Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sourceIndex on Selector nodes #287

Closed
romainmenke opened this issue Jan 24, 2024 · 2 comments · Fixed by #290
Closed

sourceIndex on Selector nodes #287

romainmenke opened this issue Jan 24, 2024 · 2 comments · Fixed by #290

Comments

@romainmenke
Copy link
Contributor

see : #36

I think this was previously also missing, was added and then removed again?
Not entirely sure how to read that change and a lot of time has passed since then.

The TypeScript typings suggest that sourceIndex should exist on all nodes and should never be undefined.

Was there a specific reason why sourceIndex is missing, or should we just add it?

@alexander-akait
Copy link
Collaborator

I’ll answer honestly - I don’t remember 😄 Anyway if you found a bug, feel free to send a PR

@romainmenke
Copy link
Contributor Author

Cool!

I am currently working around it by doing selector.first.sourceIndex but that is a bit flaky and only works if the first node wasn't removed or altered.

I'll send a PR when I find some time 🙇

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants