add an afterRollback event #292
Conversation
|
Any reason not to merge this? Let me know if you want any changes. |
| @@ -743,6 +744,20 @@ changeset.validate().then(() => { | |||
|
|
|||
| **[⬆️ back to top](#api)** | |||
|
|
|||
| #### `afterRollback` | |||
|
|
|||
| This event is triggered after a rollback of the changeset. | |||
There was a problem hiding this comment.
@bgentry Would you mind adding a few sentences detailing the "use case" for users? To me it isn't immediately obvious, but I trust that there is a valid use case.
addon/index.js
Outdated
| @@ -396,6 +397,7 @@ export function changeset( | |||
| set(this, ERRORS, {}); | |||
| (this /*: ChangesetDef */)._notifyVirtualProperties(keys) | |||
|
|
|||
| this.trigger(AFTER_ROLLBACK_EVENT); | |||
There was a problem hiding this comment.
I think to follow some other places in the code, one can do (just for reference)
let c /*: ChangesetDef */ = this;
c.trigger(BEFORE_VALIDATION_EVENT, key);
|
@snewcomer let me know if these changes are sufficient. The best I could do to explain it is to link to an existing post where I described why I needed this functionality. I think it is somewhat related to the larger issue discussed in #297, which is that the changeset does not actually represent the most recently-set values for all fields (mainly those that are invalid or haven't yet completed validations). |
|
@bgentry I think if you merge master in, we should get a passing test suite! The comment you added looks good enough from my end 👍 |
|
@snewcomer rebased as requested ✌️ |
|
@bgentry there might a |
|
@snewcomer yeah, it was a flow error because the new callback does not have a 2nd string arg (i.e. the key of the attr being changed). I changed the flow signature to |
|
@Dhaulagiri Mind taking a look at this PR? Increases the API surface, but does provide a valuable event for some use cases. |
|
@Dhaulagiri Lmk if you have time to look at these PR's today. Going to tackle a much lgr feature after this is in ☮️ |
Add an
afterRollbackevent hookThis adds a new event hook
afterRollbackthat gets called at the end of a changesetrollback(). I wouldn't have a PR for this if I could cleanly extend theChangesetclass myself, but, I can't: #178 (comment)This is required for me to have a reasonably clean solution to offirgolan/ember-changeset-cp-validations#25 . I'll post more info there to help explain why I need this.
Cheers ✌️