Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent server from crashing with SIGPIPE when terminating client #46

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

daniel-sch
Copy link
Contributor

Fixes #45

@guruofquality
Copy link
Contributor

I guess its fine to always specify the MSG_NOSIGNAL, its not like we need the sigpipe.

But the fix isnt portable for OSX and windows. Can you add an ifdef to https://github.com/pothosware/SoapyRemote/blob/master/common/SoapySocketDefs.in.hpp

/***********************************************************************
 * socket flag definitions
 **********************************************************************/
#ifndef MSG_NOSIGNAL
#define MSG_NOSIGNAL 0
#endif 

@guruofquality guruofquality changed the base branch from master to maint August 20, 2018 17:37
@guruofquality guruofquality changed the base branch from maint to master August 20, 2018 17:37
@daniel-sch
Copy link
Contributor Author

Thank you for your feedback, I added the workaround you proposed.

@guruofquality guruofquality merged commit 6efb692 into pothosware:master Aug 22, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants