Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Not working with Node.js v8 #16

Closed
leedm777 opened this issue Jun 1, 2017 · 3 comments · Fixed by #17
Closed

Not working with Node.js v8 #16

leedm777 opened this issue Jun 1, 2017 · 3 comments · Fixed by #17

Comments

@leedm777
Copy link

leedm777 commented Jun 1, 2017

I'm not seeing power-assert goodness when using Node.js v8. Using the example in the example directory:

$ node --version
v8.0.0

$ npm install --silent
<snip/>

$ npm test

> example@1.0.0 test /Users/dlee/tmp/intelli-espower-loader/example
> mocha



  FailTest
    1) is failed

  PassTest
    ✓ is passed


  1 passing (33ms)
  1 failing

  1) FailTest is failed:

      AssertionError [ERR_ASSERTION]: { name: 'Tom object' } deepEqual { name: 'Mom object' }
      + expected - actual

       {
      -  "name": "Tom object"
      +  "name": "Mom object"
       }
      
      at Decorator.concreteAssert (node_modules/empower/lib/decorator.js:61:21)
      at Function.decoratedAssert [as deepEqual] (node_modules/empower/lib/decorate.js:44:26)
      at Context.<anonymous> (test/fail-test.js:9:16)

I should have seen the super-awesome:

  assert.deepEqual(object, { name: "Mom object" })
                   |       |                      
                   |       Object{name:"Mom object"}
                   Object{name:"Tom object"}      
@twada
Copy link
Member

twada commented Jun 3, 2017

@leedm777 Thank you for reporting.
Yes. I have to deal with Node v8.
Please stay tuned.

refs power-assert-js/power-assert#85

@twada
Copy link
Member

twada commented Jun 6, 2017

@leedm777 now fixed. Thank you for reporting!

@leedm777
Copy link
Author

leedm777 commented Jun 6, 2017

Fix confirmed! Thanks for the quick response!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants