From 0719f7cc4d4a48739a91a65d9b49db4c97f9b16a Mon Sep 17 00:00:00 2001 From: Mark Rosenberg <38965626+markdoeswork@users.noreply.github.com> Date: Thu, 30 Jan 2025 12:33:14 -0500 Subject: [PATCH] Fix disabled state for link (#4190) Ruwnay https://runway.powerhrg.com/backlog_items/PLAY-1862 When using the link variant for our button kit, it is not properly applying the disabled prop. When disabled it is forced to use the button tag Maddie had the issue and reported it in the playbook room --- playbook/app/pb_kits/playbook/pb_button/button.rb | 2 +- playbook/spec/pb_kits/playbook/kits/button_spec.rb | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/playbook/app/pb_kits/playbook/pb_button/button.rb b/playbook/app/pb_kits/playbook/pb_button/button.rb index d87e53027e..2284b1e36e 100755 --- a/playbook/app/pb_kits/playbook/pb_button/button.rb +++ b/playbook/app/pb_kits/playbook/pb_button/button.rb @@ -65,7 +65,7 @@ def link_options end def tag - link ? "a" : "button" + link && !disabled ? "a" : "button" end def valid_emoji(icon) diff --git a/playbook/spec/pb_kits/playbook/kits/button_spec.rb b/playbook/spec/pb_kits/playbook/kits/button_spec.rb index 553ee10706..977b164700 100644 --- a/playbook/spec/pb_kits/playbook/kits/button_spec.rb +++ b/playbook/spec/pb_kits/playbook/kits/button_spec.rb @@ -32,6 +32,9 @@ it "returns 'a' when link is provided" do expect(subject.new(link: true).tag).to eq "a" end + it "returns 'button' when link and disabled" do + expect(subject.new(link: true, disabled: true).tag).to eq "button" + end end describe "#link_options" do