From 4f00b2afe351e1072771fb1a048027a7262bd562 Mon Sep 17 00:00:00 2001 From: Lucas Videla Date: Mon, 14 Feb 2022 15:14:56 -0300 Subject: [PATCH 1/2] Addressing deprecation warning in order to avoid using Kernel.open --- playbook/app/pb_kits/playbook/pb_icon/icon.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playbook/app/pb_kits/playbook/pb_icon/icon.rb b/playbook/app/pb_kits/playbook/pb_icon/icon.rb index 225ed611ff..1cb11c9a8b 100644 --- a/playbook/app/pb_kits/playbook/pb_icon/icon.rb +++ b/playbook/app/pb_kits/playbook/pb_icon/icon.rb @@ -73,7 +73,7 @@ def custom_icon_classname def render_svg(path) if File.extname(path) == ".svg" - doc = Nokogiri::XML(open(path)) # rubocop:disable Security/Open + doc = Nokogiri::XML(File.open(path)) svg = doc.at_css "svg" svg["class"] = "pb_custom_icon " + object.custom_icon_classname raw doc From f6981af54db9f8ad429f7cb7ccd1d201d02345bf Mon Sep 17 00:00:00 2001 From: Lucas Videla Date: Tue, 15 Feb 2022 17:09:41 -0300 Subject: [PATCH 2/2] Changed File.open for URI.open --- playbook/app/pb_kits/playbook/pb_icon/icon.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playbook/app/pb_kits/playbook/pb_icon/icon.rb b/playbook/app/pb_kits/playbook/pb_icon/icon.rb index 1cb11c9a8b..6e9c967ee8 100644 --- a/playbook/app/pb_kits/playbook/pb_icon/icon.rb +++ b/playbook/app/pb_kits/playbook/pb_icon/icon.rb @@ -73,7 +73,7 @@ def custom_icon_classname def render_svg(path) if File.extname(path) == ".svg" - doc = Nokogiri::XML(File.open(path)) + doc = Nokogiri::XML(URI.open(path)) # rubocop:disable Security/Open svg = doc.at_css "svg" svg["class"] = "pb_custom_icon " + object.custom_icon_classname raw doc