Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-210] Typescript Conversion: Bread Crumbs #1976

Merged
merged 4 commits into from
Aug 3, 2022
Merged

[PLAY-210] Typescript Conversion: Bread Crumbs #1976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5460d43
Convert Bread Crumbs to Typescript
augustomallmann Jul 25, 2022
5c002f1
Merge branch 'master' into typescript-bread-crumbs
augustomallmann Jul 26, 2022
ea69de2
Remove file extension from import
augustomallmann Jul 26, 2022
e51698a
Merge branch 'master' into typescript-bread-crumbs
jasperfurniss Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...ook/pb_bread_crumbs/_bread_crumb_item.jsx → ...ook/pb_bread_crumbs/_bread_crumb_item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,15 @@ import {
} from '../utilities/props'

type BreadCrumbItemProps = {
aria?: object,
aria?: {[key: string]: string},
className?: string,
data?: object,
id?: string,
component?: element
component?: "a" | "span",
[x:string]: any;
}


const BreadCrumbItem = (props: BreadCrumbItemProps) => {
const {
aria = {},
Expand All @@ -28,12 +31,13 @@ const BreadCrumbItem = (props: BreadCrumbItemProps) => {
} = props
const ariaProps = buildAriaProps(aria)
const dataProps = buildDataProps(data)
const Component = component || 'span';
const css = classnames(
buildCss('pb_bread_crumb_item_kit'),
globalProps(props),
className
)
const Component = component || 'span'

return (
<div
{...ariaProps}
Expand Down
4 changes: 2 additions & 2 deletions ...laybook/pb_bread_crumbs/_bread_crumbs.jsx → ...laybook/pb_bread_crumbs/_bread_crumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ import {
} from '../utilities/props'

type BreadCrumbsProps = {
aria?: object,
aria?: {[key: string]: string},
className?: string,
data?: object,
id?: string,
text?: string,
children?: node
children?: React.ReactChild[] | React.ReactNode,
}
const BreadCrumbs = (props: BreadCrumbsProps) => {
const {
Expand Down
2 changes: 1 addition & 1 deletion playbook/app/pb_kits/playbook/pb_bread_crumbs/docs/_bread_crumbs_default.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react'
import BreadCrumbs from '../_bread_crumbs.jsx'
import BreadCrumbs from '../_bread_crumbs'
import { Icon, Title } from '../../'
import BreadCrumbItem from '../_bread_crumb_item'

Expand Down