Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-395]-Fixed Hover State on Selectable List Rails Kit #2116

Merged
merged 2 commits into from
Oct 19, 2022
Merged

[PLAY-395]-Fixed Hover State on Selectable List Rails Kit #2116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
494f2e8
PLAY-395-Fixed Hover State on Selectable List Rails Kit
nidaqg Oct 10, 2022
1c23ddb
Fixed spec test
nidaqg Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playbook/app/pb_kits/playbook/pb_selectable_list/selectable_list_item.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class SelectableListItem < Playbook::KitBase
default: {}

def classname
generate_classname("pb_selectable_list_item_kit")
generate_classname("pb_item_kit")
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions playbook/spec/pb_kits/playbook/kits/selectable_list_item_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

describe "#classname" do
it "returns namespaced class name", :aggregate_failures do
expect(subject.new({}).classname).to eq "pb_selectable_list_item_kit"
expect(subject.new(classname: "additional_class").classname).to eq "pb_selectable_list_item_kit additional_class"
expect(subject.new({}).classname).to eq "pb_item_kit"
expect(subject.new(classname: "additional_class").classname).to eq "pb_item_kit additional_class"
end
end
end